Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got non-zero code from vifm in neovim #4

Closed
artur-shaik opened this issue Jan 23, 2016 · 7 comments
Closed

Got non-zero code from vifm in neovim #4

artur-shaik opened this issue Jan 23, 2016 · 7 comments
Assignees

Comments

@artur-shaik
Copy link

Vifm just does not start in neovim. Any thoughts?

@xaizek
Copy link
Member

xaizek commented Jan 23, 2016

I confirm the issue, but it's not related to the plugin, even :!vifm doesn't work there:

:!vifm

Terminal error.
shell returned 1

I guess this comes from neovim handling spawned processes incorrectly (ioctl(0, TIOCGWINSZ, &ws) call fails) and seems to be an issue on their side (if they emulate terminal, then there is something wrong with the emulation). Not 100% sure about it, but everything works fine outside neovim... (Maybe there is an option to work around this behaviour, I don't know.)

@xaizek
Copy link
Member

xaizek commented Jan 23, 2016

Yeah, one can't even run neovim from neovim:

:!./nvim

Vim: Warning: Output is not to a terminal
Vim: Warning: Input is not from a terminal
Vim: Error reading input, exiting...

Vim: Finished.
 [?1049h [H [J [?2004h [?1004h [8;24;80t [H [J [1;1H [1;1H [34h [?25h [?25l [?1002h [?1006h [H [J [1;1H [2;1H [m  [94m~                                                                                [3;1H~
shell returned 1

@artur-shaik
Copy link
Author

Ou yeah, just realized that is limitation in neovim. There are some issues about this. Here is one: neovim/neovim#1496.
And here workaround implemented for ranger: https://github.com/hut/ranger/issues/279. May be can be implemented for this plugin too?

@xaizek
Copy link
Member

xaizek commented Jan 23, 2016

:-( that looks ugly... hope it's the only thing related to the plugin they broke there.

Thanks for the information, I'll try to make it work.

@artur-shaik
Copy link
Author

That would be great.

And thanks, for vifm and plugin.

On 01-23 (04:16), xaizek wrote:

:-( that looks ugly... hope it's the only thing related to the plugin they
broke there.

Thanks for the information, I'll try to make it work.


Reply to this email directly or [1]view it on GitHub.

Reverse link: [2]unknown

References

Visible links

  1. Got non-zero code from vifm in neovim #4 (comment)
  2. Got non-zero code from vifm in neovim #4 (comment)

Best regards,
Artur Shaikhullin

xaizek added a commit to xaizek/vifm that referenced this issue Jan 23, 2016
That thing has broken `system()` and :! commands.

Thanks to Artur Shaik (a.k.a. artur-shaik).

See vifm/vifm.vim#4 on GitHub.
xaizek added a commit that referenced this issue Jan 23, 2016
That thing has broken `system()` and :! commands.

Thanks to Artur Shaik (a.k.a. artur-shaik).

See #4 on GitHub.
@xaizek
Copy link
Member

xaizek commented Jan 23, 2016

Should generally work now. At least one thing that's not working is error messages, they aren't printed from callback (once they got printed in a terminal... I didn't get why), don't see how to fix them, so leaving as is. One also might need to have 'hidden' option enabled or opening terminal will fail.

@xaizek xaizek self-assigned this Jan 23, 2016
@artur-shaik
Copy link
Author

Nice. It works as expected. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants