Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :com {cmd} not recognizes FOREIGN_CMDs #976

Merged
merged 3 commits into from
Dec 30, 2023

Conversation

haolian9
Copy link
Contributor

@haolian9 haolian9 commented Dec 30, 2023

Hi, this tries to fix #973.

after this PR, I believe another relevant problem is :com <tab>, to be specific, the completion of :com should show FOREIGN_CMDs too.

@haolian9 haolian9 changed the title WIP: Fix :com {cmd} not recognizes FOREIGN_CMDs Fix :com {cmd} not recognizes FOREIGN_CMDs Dec 30, 2023
@xaizek
Copy link
Member

xaizek commented Dec 30, 2023

Thanks. And a separate thanks for the test! I've pushed minor updates and will merge once CI passes (just in case).

@xaizek xaizek merged commit 392c4c0 into vifm:master Dec 30, 2023
1 check passed
@xaizek
Copy link
Member

xaizek commented Dec 30, 2023

I forgot to address:

after this PR, I believe another relevant problem is :com <tab>, to be specific, the completion of :com should show FOREIGN_CMDs too.

Yes, that's correct.

@haolian9 haolian9 deleted the inspect_foreign_cmd branch December 31, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

cmds added via vifm.cmds.add are not visible to :command {name}
2 participants