Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support parse from reader #2

Merged
merged 1 commit into from
Apr 19, 2022
Merged

feat: support parse from reader #2

merged 1 commit into from
Apr 19, 2022

Conversation

d1nfinite
Copy link
Contributor

sometime we can't work in standard filesystem, so filepath can't work

vifraa
vifraa requested changes Apr 19, 2022
View reviewed changes
Copy link
Owner

@vifraa vifraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, see my comments revolving two of the added functions.

gopom.go Outdated Show resolved Hide resolved
gopom.go Outdated Show resolved Hide resolved
@d1nfinite
Copy link
Contributor Author

I removed two non-necessary functions and it looks like they can merge to master

@vifraa
Copy link
Owner

vifraa commented Apr 19, 2022

Looks good 👍

@vifraa vifraa merged commit 40b6a78 into vifraa:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifraa vifraa vifraa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d1nfinite @vifraa