Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for Marshaling Project object #4

Merged
merged 2 commits into from
Oct 15, 2022
Merged

support for Marshaling Project object #4

merged 2 commits into from
Oct 15, 2022

Conversation

mundra-ankur
Copy link
Contributor

At present, when you want to marshal the parsed object back to XML, it gives error: xml unsupported type: map[string]string

  • Similar to UnmarshalXML for properties object, added MarshalXML for properties
  • Now we can marshal the parsed object back to xml file

@jonasagx
Copy link

Thanks for submitting this PR! It would be awesome to validate it with a test.

@mundra-ankur
go test for marshaling the project
1cee1a4 
Signed-off-by: Ankur Mundra <amundra@redhat.com>
@mundra-ankur
Copy link
Contributor Author

Thanks for submitting this PR! It would be awesome to validate it with a test.

Added test!

@vifraa vifraa merged commit a4fa829 into vifraa:main Oct 15, 2022
@vifraa
Copy link
Owner

vifraa commented Oct 15, 2022

Nice job! Merging and creating a new release.

@iseki0 iseki0 mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mundra-ankur @jonasagx @vifraa