Add pagination #53
Closed
Add pagination #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
commented
Oct 12, 2018
| @@ -66,6 +66,7 @@ | |||
| "dependencies": { | |||
| "classnames": "~2.2.6", | |||
| "lodash.sortby": "^4.7.0", | |||
| "query-string": "^6.2.0", | |||
There was a problem hiding this comment.
ArsArsenal will build a query for you. You just have to return an object from the new listQuery option
nhunzaker
commented
Oct 12, 2018
src/components/table-view/index.tsx
Outdated
| @@ -45,15 +46,15 @@ class TableView extends React.Component<Props, State> { | |||
| return Array.isArray(picked) ? picked.indexOf(id) >= 0 : id === picked | |||
| } | |||
|
|
|||
| renderRow(item: Record, index: number) { | |||
| renderRow(item: Record, index: number, list) { | |||
There was a problem hiding this comment.
Ack, this is gonna break TS.
solomonhawk
approved these changes
Oct 12, 2018
src/components/gallery.tsx
Outdated
| @@ -17,8 +19,13 @@ interface Props { | |||
| picked: Array<string | number> | |||
| } | |||
|
|
|||
| function getAnimationDelay(index) { | |||
| let outer = container.getBoundingClientRect() | ||
| let inner = nextChild.getBoundingClientRect() | ||
|
|
||
| if (inner.top < outer.bottom + outer.height * 0.5) { |
There was a problem hiding this comment.
Is there a simpler and perhaps more performant way to do this using scrollTop and scrollHeight? The answer may be no but I wanted to ask.
There was a problem hiding this comment.
I can give it another shot. I really strugged with this.
| render: state => null | ||
| } | ||
|
|
||
| static getDerivedStateFromProps(props: Props, lastState: State) { |
This commit adds pagination to ArsArsenal. It breaks up the data fetcher and URL building options to make URL building clearer and adds logic ot watch the last item in a list to trigger a new page of data. I need some way of identicating that pagination is done. In a follow-up commit, I'd like to add a new option for "Pagination is done". It would be nice to reduce configuration of this to be bear minimum.
|
Types were a wreck. Fixed. I'll send some follow-up PRs to this branch, I still need to add a way to tell the pagination to stop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds pagination to ArsArsenal. It breaks up the data
fetcher and URL building options to make URL building clearer and
adds logic ot watch the last item in a list to trigger a new page
of data.
I need some way of identicating that pagination is done. In a
follow-up commit, I'd like to add a new option for "Pagination is
done". It would be nice to reduce configuration of this to be bear
minimum.