Add hint property to field component #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make this input easier for users, do you think you could just have them paste in the YouTube Url and then parse it yourself? That might be easier than training people to understand what they need to put in here. |
|
👍 |
| element : 'input', | ||
| type : 'text' | ||
| } | ||
| }, | ||
|
|
||
| getInitialState() { | ||
| return { | ||
| hintId: `hint-col-field-${uid++}` |
There was a problem hiding this comment.
seems like it could be nicer to use a more global uuid assignment mechanism for things like this.
There was a problem hiding this comment.
We could use https://www.npmjs.com/package/uid
|
one minor comment. good stuff 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #101