Pass Presenter send method along with model #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
That was fast |
|
👍 |
nhunzaker
force-pushed
the
presenter-passes-send
branch
from
40a58aa
to
dacb25c
Compare
That way it is easily selectable within Enzyme
We found ourselves wrapping the direct children of the Presenter component with `withIntent` quite often. This PR configures the Presenter to pass down `send` along with the model.
nhunzaker
force-pushed
the
presenter-passes-send
branch
from
dacb25c
to
3d577bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found ourselves wrapping the direct children of the Presenter component with
withIntentquite often. This PR configures the Presenter to pass downsendalong with the model.Fixes #203