Replace history.invoke with event emissions #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
force-pushed
the
history-events
branch
from
147ef50
to
726377c
Compare
Codecov Report
@@ Coverage Diff @@
## 12-dev #293 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 801 802 +1
=====================================
+ Hits 801 802 +1
Continue to review full report at Codecov.
|
Instead of having the history track a list of microcosms, history now emits events: - append: when an action is created - update: when an action has changed - remove: when an action has archived or been removed - reconcile: when a history has completed reconciliation - release: when a history has done all work, and it is safe to emit a change event The release and reconcile events used to be the same operation, however by keeping them separate, we can start to expose the ability to control the update process. Specifically, I want to support a future feature where users can implement batching.
nhunzaker
force-pushed
the
history-events
branch
from
726377c
to
c5ed505
Compare
|
👍 |
|
Thanks, gents! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the history track a list of microcosms, history now
emits events:
The release and reconcile events used to be the same operation, however by keeping them separate, we can start to expose the ability to control the update process. Specifically, I want to support a future feature where users can implement batching.