Presenter::intercept can have multiple handlers #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to achieve consistency with effects and domains, the presenter intercept method can now accept an array of handlers.
nhunzaker
force-pushed
the
multiple-presenter-handlers
branch
from
f7687e3
to
afe6498
Compare
cwmanning
reviewed
Feb 20, 2018
| class Test extends Presenter { | ||
| intercept() { | ||
| return { | ||
| test: [one, two] |
cwmanning
approved these changes
Feb 20, 2018
|
looks great 👍 |
|
Thanks guys! |
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
=========================================
Coverage ? 97.65%
=========================================
Files ? 29
Lines ? 681
Branches ? 143
=========================================
Hits ? 665
Misses ? 13
Partials ? 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to achieve consistency with effects and domains, the
presenter intercept method can now accept an array of handlers.