Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Team Section #28

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

aayushpathak11
Copy link
Contributor


Description πŸ“œ

  • Modified DevsActivity to make Team section completely dynamic using Retrofit.
  • On clicking a particular tile user will be redirected to his/her github page.
  • If the name is not available then username will be used in particular tile.
  • Used Lottie Animation for better user experience.
  • Added Shimmer effect to fill up the time when recycler view is loading.
    Fixes # 27

Domain of Contribution πŸ“Š

  • Documentation
  • Android (Kotlin)
  • Backend (Express)

Checklist βœ…

  • I follow Code of Conduct of this project.
  • I have performed a self-review of my own code or work.
  • My changes generates no new warnings.
  • I'm GSSOC'22 contributor

Screenshots / Gif πŸ“Έ

20220310_210045


@aayushpathak11
Copy link
Contributor Author

Hello @vigneshshettyin
Could you please review the PR and let me know any suggestions/changes.

@vigneshshettyin vigneshshettyin added GSSoC22 Level3 GSSOC'22 Level 3 labels Mar 11, 2022
@vigneshshettyin
Copy link
Owner

Hey, @aayushpathak11 thanks for contributing!

@vigneshshettyin vigneshshettyin linked an issue Mar 11, 2022 that may be closed by this pull request
1 task
@vigneshshettyin vigneshshettyin merged commit 7f15ade into vigneshshettyin:main Mar 11, 2022
@aayushpathak11 aayushpathak11 deleted the TeamSection branch March 11, 2022 17:44
@vigneshshettyin
Copy link
Owner

Hey, @aayushpathak11 if you are interested you can raise issue to add shimmerframelayout for mainactivity, supportactivity etc..

@aayushpathak11
Copy link
Contributor Author

@vigneshshettyin yes sir I am interested.
Can you please explain more like where they need shimmer layout.

@aayushpathak11
Copy link
Contributor Author

Also sir @vigneshshettyin
I would be more than excited to work upon new features in the app (as currently i am not very well versed with codebase so i am not able to come up with what new can be added) so if you have anything which you think can be added or changed please share , would like to contribute to the best of my efforts.

@vigneshshettyin
Copy link
Owner

@vigneshshettyin yes sir I am interested. Can you please explain more like where they need shimmer layout.

In mainactivity file there is a recycle view which is used to list all the meetings of user. Also, in the supportactivity there is recycle view which quires the support updates from fire store. @aayushpathak11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSoC22 Level3 GSSOC'22 Level 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Modify the team activity in the app.
2 participants