Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hand Solver #1

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Implement Hand Solver #1

merged 2 commits into from
Nov 23, 2021

Conversation

LeNitrous
Copy link
Member

No description provided.

Moetion/Hands/HandSolver.cs Show resolved Hide resolved
Moetion/Hands/HandSolver.cs Show resolved Hide resolved
Moetion/Hands/HandSolver.cs Show resolved Hide resolved
Copy link
Contributor

@Speykious Speykious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, but I think there remains a lot of unnecessary copying (probably because of the original JS implementation?).

Moetion/Hands/HandSolver.cs Show resolved Hide resolved
Moetion/Hands/HandSolver.cs Show resolved Hide resolved
Moetion/Hands/HandSolver.cs Show resolved Hide resolved
Moetion/Hands/HandSolver.cs Outdated Show resolved Hide resolved
Copy link
Member

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need to document a lot of this since Kalidokit never doc'ed this, but LGTM

@sr229 sr229 merged commit 7e6b929 into master Nov 23, 2021
@sr229 sr229 deleted the nitrous/hand-solver branch November 23, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants