Improvement ideas and some bug fixes #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ermanimer
commented
Jul 29, 2021
•
ermanimer
commented
- Ignore error while closing writer
- Simplify return of the Run method
- Fix error format in Validate method
- Clone default HTTP transport instead of creating a new one
- Remove DisableCompression setting from HTTP client since Statoo accepts gzip encoding
- Remove unnecessary nil check while closing response body
- Ignore errors while closing response bodies
- Fix typos
…lone default http transport instead of creating new one also remove DisableCompression setting since statoo acceps gzip encoding, remove unnecassary nil check while closing response body, ignore error while closing response bodies,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.