reject falsy will not emit an error

vigour-io · Dec 12, 2016 · e39d7d1 · e39d7d1
1 parent e3587f1
commit e39d7d1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/lib/async.js b/lib/async.js
@@ -14,7 +14,7 @@ const extendSet = (t, val, stamp) => {
   }
 }
 
-const error = (t, err, stamp) => generic(root(t), 'error', err, stamp)
+const error = (t, err, stamp) => err && generic(root(t), 'error', err, stamp)
 
 const isGeneratorFunction = obj => {
   const constructor = obj.constructor

diff --git a/test/async.js b/test/async.js
@@ -185,7 +185,19 @@ test('async - promise all', t => {
     return 'lulllz'
   }))
 
-  a.once('lulllz', () => { t.end() })
+  a.once('lulllz', () => {
+    var cnt = 0
+    a.on('error', () => ++cnt)
+
+    a.set(new Promise((resolve, reject) => {
+      reject()
+    }))
+
+    process.nextTick(() => {
+      t.equal(cnt, 0, 'does not fire error event')
+      t.end()
+    })
+  })
 })
 
 test('async - advanced', t => {

diff --git a/test/index.js b/test/index.js
@@ -10,7 +10,7 @@ require('./on')
 require('./remove')
 require('./compute')
 require('./props')
-require('./async')
 require('./references')
 require('./subscribe')
 require('./context')
+require('./async')