Skip to content

Commit

Permalink
[SPARK-44294][UI] Fix HeapHistogram column shows unexpectedly w/ sele…
Browse files Browse the repository at this point in the history
…ct-all-box

### What changes were proposed in this pull request?

This PR fixes the bug that the last element of execOptionalColumns does not point to the executor removeReason but HeapHistogram.

### Why are the changes needed?

bugfix, otherwise, after users've checked the select-all-box, an unexpected HeapHistogram will show with a dead link
### Does this PR introduce _any_ user-facing change?

no, bugfix and not released

### How was this patch tested?

locally built and tested to verify the HeapHistogram invisible

<img width="1768" alt="image" src="https://github.com/apache/spark/assets/8326978/1fa108a6-5598-4c90-855c-35104ed2c740">

Closes apache#41847 from yaooqinn/SPARK-44294.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 4b77aad)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
  • Loading branch information
yaooqinn authored and dongjoon-hyun committed Jul 5, 2023
1 parent 2cfd674 commit a60962a
Showing 1 changed file with 3 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function totalDurationColor(totalGCTime, totalDuration) {
}

var sumOptionalColumns = [3, 4];
var execOptionalColumns = [5, 6, 7, 8, 9, 10, 13, 14, 25];
var execOptionalColumns = [5, 6, 7, 8, 9, 10, 13, 14, 26];
var execDataTable;
var sumDataTable;

Expand Down Expand Up @@ -573,15 +573,7 @@ $(document).ready(function () {
],
"order": [[0, "asc"]],
"columnDefs": [
{"visible": false, "targets": 5},
{"visible": false, "targets": 6},
{"visible": false, "targets": 7},
{"visible": false, "targets": 8},
{"visible": false, "targets": 9},
{"visible": false, "targets": 10},
{"visible": false, "targets": 13},
{"visible": false, "targets": 14},
{"visible": false, "targets": 26}
{"visible": false, "targets": execOptionalColumns}
],
"deferRender": true
};
Expand Down Expand Up @@ -713,10 +705,8 @@ $(document).ready(function () {
"searching": false,
"info": false,
"columnDefs": [
{"visible": false, "targets": 3},
{"visible": false, "targets": 4}
{"visible": false, "targets": sumOptionalColumns}
]

};

sumDataTable = $(sumSelector).DataTable(sumConf);
Expand Down

0 comments on commit a60962a

Please sign in to comment.