Add for comprehension test to demonstrate the issue with dotty coverage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaykramesh
commented
Mar 8, 2023
| Apply | ||
| false | ||
| 0 | ||
| false |
There was a problem hiding this comment.
this should be true, or maybe never appear?
vijaykramesh
commented
Mar 8, 2023
| Ident | ||
| false | ||
| 0 | ||
| false |
vijaykramesh
commented
Mar 8, 2023
| Apply | ||
| false | ||
| 0 | ||
| false |
There was a problem hiding this comment.
If I make all the List(1) List(2) and List List true here then the output matches what I'd expect:
|
for the sake of my own debugging later, when running this locally need to invoke the tests like: |
|
Hi @vijaykramesh. Good work. How can we drive this forward/fix it? |
vijaykramesh
force-pushed
the
vr_coverage_issues
branch
from
6af05ca
to
f19aebe
Compare
vijaykramesh
force-pushed
the
vr_coverage_issues
branch
from
f19aebe
to
72af0ee
Compare
|
@rolandtritsch see scala#17239 I'm working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test clearly indicates the current problem with coverage in dotty:
will move to upstream once I can actually fix it!