Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character '+' is only allowed at the beginning of filename #1407

Closed
xar opened this issue Jan 3, 2024 · 7 comments
Closed

Character '+' is only allowed at the beginning of filename #1407

xar opened this issue Jan 3, 2024 · 7 comments
Labels
enhancement ✨ New feature or request

Comments

@xar
Copy link

xar commented Jan 3, 2024

Description

We are using vike for part of our application but It's in the same mono-repo as our Capacitor app. When I'm trying to bundle things I'm getting following error. Is there any way how to specify that vike should ignore those files?

Thanks

Error: [vike][Wrong Usage] Character '+' is only allowed at the beginning of filenames: make sure .../ios/App/Pods/GTMAppAuth/GTMAppAuth/Sources/Public/GTMAppAuth/GTMAppAuthFetcherAuthorization+Keychain.h doesn't contain any '+' in its filename other than its first letter

@xar xar added the bug 💥 label Jan 3, 2024
@brillout brillout added enhancement ✨ New feature or request and removed bug 💥 labels Jan 3, 2024
@brillout
Copy link
Member

brillout commented Jan 3, 2024

Closing because it isn't a bug, but let's continue the discussion.

Can you remove the + symbol from your file names? I think it's best if + is completely owned by Vike (we have other plans with it). But let's see if that can cause problems.

@brillout brillout closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@xar
Copy link
Author

xar commented Jan 3, 2024

thanks for reply.

As I said we have big mono-repo where is:

  • Marketing site that uses Vike
  • SPA - vue, vite, typescript
  • Capacitor infrastructure to build mobile app from SPA

All the parts share same vue components only results in different bundles.

I'm unable to control all the files that other platforms need. In this particular case there are some files that are part of iOS build and contains + in the name :/ . I would really appreciate If there would be a way how to limit vike so It doesn't look to every subfolder in actual directory or option to skip scan of specific directories.

For better understanding here is the folder structure of project:

android/           
ios/               
resources/
collaboration/    
node_modules/      
scripts/
components/        
packages/          
shared/
coverage/         
pages/             
src/
dist/              
playwright-report/ test-results/
editor/          
playwright/        
tests/
functions/         
utils/
public/

And the vike part needs only things from shared,pages,src,utils but does the scan for all other directories as well. And if there is file with + in the name It fails to build.

@brillout
Copy link
Member

brillout commented Jan 3, 2024

I see, let's find a solution for this.

What's your Vike version?

iOS build and contains + in the name :/

Do they (/ shouldn't they) match .gitignore?

@brillout brillout reopened this Jan 3, 2024
@xar
Copy link
Author

xar commented Jan 3, 2024

I'm running on latest 0.4.153 - actually the issue appeared because I did upgrade from an old vite-plugin-ssr.

I cannot include those files in .gitignore as they need to be a part of repo to actually build product in CI and other machines.

The not optimal way I can do now is to do regexp when building the site using vike and remove all the files that contains + in the name.. :/ I would rather not do that if possible.

@brillout
Copy link
Member

brillout commented Jan 3, 2024

Fix pre-released in 0.4.153-commit-159c659. I didn't test it but I believe it should now work.

Let me know if you have any other issues.

Btw. would your company be up for sponsoring?

@xar
Copy link
Author

xar commented Jan 4, 2024

Thank you I will try out fix.

As a company we are currently very early in revenue trying to bootstrap.
I have sent you at least some small amount from my personal account for now.

Thank you for your work:)

@lourot
Copy link
Contributor

lourot commented Jan 4, 2024

Hey @xar, I have just seen your sponsoring, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants