Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some text translatable #21

Closed
wants to merge 1 commit into from
Closed

Conversation

huobos
Copy link
Contributor

@huobos huobos commented Jan 25, 2017

I found some text are not translatable during Chinese translation. Make them translatable.

@rnorris
Copy link
Collaborator

rnorris commented Jan 25, 2017

Thanks for these, however I don't think I can directly use this commit.

For instance the calls to vik_waypoint_set_symbol() are to an internal lookup table and then match a specific Garmin GPX symbol text. I think the text is the interface and hence not translatable.

For OSM map types in osm.c - there's probably more translations too add.

Some other cases I may have to consider further where the appropriate place for the '_( )' should go, although mostly it appears correct.

Thus I expect to manually review each change in slow time and probably commit in smaller chunks for a more fine grained control (e.g. the changes that just replace gettext with _).

And then I'll apply your additional Chinese translations that are still relevant (most of them) in one go.

Hopefully this is an agreeable approach.

@rnorris
Copy link
Collaborator

rnorris commented Feb 25, 2017

I've broken down the commit into various smaller commits and applied to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants