Fix a few memory issues (3x heap-buffer-overflow, race condition?) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've applied the first two changes. "Please review last commit (a_background_update_status) with care, i'm not sure why that variable was static." Since this code comes from the first public version of Viking, I can only assume the original author wrote it this way under the impression it would be 'faster' by avoiding unnecessary memory allocations. However these gains are very marginal since this operation doesn't happen thousands of times and potentially open to race conditions when accessed via multiple threads. If you want I can apply the commit and remove the 'NOTE: ... do not understand....' text in the comment? |
|
@rnorris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I'm not sure if GitHub PR is the prefered contribution method, but i would prefer not to touch SF :(
Recently i have been using this program a lot, so i though i may aswell try to contribute something back :)
So here are a few fixes for some of the issues i was able to reproduce and fix.
Please review last commit (a_background_update_status) with care, i'm not sure why that variable was static.
PS: i have tested a patch in bug 121, and so far it seems to fix that issue. I'm looking forward to seeing it merged.
Please pull.
Thanks!