Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SidebarItem without childs, CustomIconName not passed to Icon #286

Closed
Capellio opened this issue Jul 13, 2023 · 0 comments · Fixed by #290
Closed

SidebarItem without childs, CustomIconName not passed to Icon #286

Capellio opened this issue Jul 13, 2023 · 0 comments · Fixed by #290
Assignees
@gvreddy04
Labels
area-sidebar bug Something isn't working
Milestone
1.9.5

Comments

@Capellio
Copy link

CustomIconName is passed to the Icon when the SidebarItem has childs, but not when there are none.

https://github.com/vikramlearning/blazorbootstrap/blame/263eb9976ff7942cfe4d8d317f2a00803bc53d49/blazorbootstrap/Components/Sidebar/SidebarItem.razor#L43
@gvreddy04 gvreddy04 added area-sidebar enhancement New feature or request labels Jul 13, 2023
@gvreddy04 gvreddy04 added this to the 1.9.5 milestone Jul 13, 2023
@gvreddy04 gvreddy04 added the bug Something isn't working label Jul 16, 2023
@gvreddy04 gvreddy04 self-assigned this Jul 16, 2023
@gvreddy04 gvreddy04 removed the enhancement New feature or request label Jul 16, 2023
gvreddy04 added a commit that referenced this issue Jul 16, 2023
@gvreddy04
SidebarItem without childs, CustomIconName not passed to Icon #286
6663162
@gvreddy04 gvreddy04 linked a pull request Jul 16, 2023 that will close this issue
SidebarItem without childs, CustomIconName not passed to Icon #286 #290
Merged
gvreddy04 added a commit that referenced this issue Jul 16, 2023
@gvreddy04
SidebarItem without childs, CustomIconName not passed to Icon #286 (#290
2b3f85c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvreddy04 gvreddy04

Labels
area-sidebar bug Something isn't working
Projects
None yet
Milestone
1.9.5
Development

Successfully merging a pull request may close this issue.

SidebarItem without childs, CustomIconName not passed to Icon #286 vikramlearning/blazorbootstrap
2 participants
@gvreddy04 @Capellio