#510 - Fix Button href not updating #548
Conversation
| @@ -201,9 +201,6 @@ private void SetAttributes() | |||
| if (!Attributes.TryGetValue("role", out _)) | |||
| Attributes.Add("role", "button"); | |||
|
|
|||
| if (!Attributes.TryGetValue("href", out _)) | |||
| Attributes.Add("href", To!); | |||
|
|
|||
There was a problem hiding this comment.
@MarvinKlein1508 Instead of changing the markup, please add an else statement for consistency.
|
@MarvinKlein1508 Please share the scenario in which you are updating the href attribute value of a link. This will help me understand your scenario. |
|
@gvreddy04 the HREF will be updated when you are using built in Virtualization to display data. There is a minimal repo in #510 |
|
@gvreddy04 the same could also be happening for all other parameters. Instead of applying them one by one the component should add additional attributes provided by default and use the blazor parameters within the DOM itself. A common use case for this is displaying lists with links in a virtualized component which uses pagination |
|
Added another commit. Also applied same logic to |
No description provided.