New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tracing initial commit #4

Closed

gtzo-anchorage wants to merge 1 commit into vikstrous:master from gtzo-anchorage:provide-tracing

Contributor

gtzo-anchorage commented Oct 11, 2022 •

edited

Loading

Provide a context to the NewLoader function, and support a WithTracing config.
This allows more granular tracing of the loader internals.

Open questions:

what is the best way to conditionally run tracing (go pattern)? I could put span start/ends behind a flag conditional on the presence of a tracer in the loader config, but this seems clunky.
where is the best place to provide a name for the span?
what is the best way to write tests for this? i've just been using a simple sandbox test that creates a dummy loader with associated spans for Jaeger, but that is part of repo.


          init

d6fcb26

gtzo-anchorage closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment