some refactor in BaseCommand class #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladev95
commented
Apr 24, 2023
miladev95
commented
- The code currently modifies the $model variable in place several times. While this is not necessarily a problem, it can make the code harder to follow. Consider using separate variables for the modified versions of $model, rather than overwriting it each time.
- using the DIRECTORY_SEPARATOR constant. This can make the code more portable between different operating systems.
- it returns only a string instead of an array or a string, since the is_dir() check is only needed to determine the namespace to use.
…of $model - use DIRECTORY_SEPARATOR constant instead of hard-coding the backslash - it returns only a string instead of an array or a string, since the is_dir() check is only needed to determine the namespace to use.
|
The source code you have modified is taken from the Laravel Core (see here), and I believe they are experienced than us in this aspect. This does not mean that your solution is less effective, it's just that I think it should stay as it is. Thank you very much for your effort, if you see any other shortcomings, do not hesitate to contribute. Or if you want to discuss this topic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.