Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use follow-redirects instead of default http to support redirecting #244

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marcelpanse
Copy link

With this lib, the proxy will fully support websites that use redirects (like google.com) and still proxy the site correctly (without this the browser will redirect and stop using the proxy).

@wlepinski
Copy link

What do we need to approve this? I'm facing the exact same problem.

@monkpow
Copy link
Collaborator

monkpow commented Sep 18, 2017

@wlepinski @marcelpanse
To accept this as a patch, it would need to be an option, and off by default off. It would also need a minimal test.
I like this idea, so eventually I'll pick it up if you don't.

@wlepinski
Copy link

@monkpow correct if I'm wrong but I think the follow-redirects handles this. We don't need an option.

@marcelpanse
Copy link
Author

@wlepinski No, this fork will follow redirects automatically by default, I didn't make an option for it.

@monkpow
Copy link
Collaborator

monkpow commented Sep 28, 2017

@marcelpanse @wlepinski It does need an option. I understand that you're saying that the library will follow redirects automatically by default; I'm not certain that all installed users will want to switch to follow-redirects silently when they next upgrade the library. We'll need to give authors the opportunity to opt-in (rather than opting them in silently) until the next major release. If follow-redirects is popular, I'd consider making it default on a subsequent release.

@matthewwithanm
Copy link

I needed this option today. Ended up just vendoring this branch 😢

@rajsite
Copy link

rajsite commented Feb 5, 2018

Made a fork of @marcelpanse's branch to use as a git dependency from npm as well. Looking forward to when a flag is added so this can go in!

@JSchneidler
Copy link

Any update on this? Or does anyone have a good workaround to suggest?

@monkpow
Copy link
Collaborator

monkpow commented Jun 8, 2018

@JSchneidler yep, there actually is an update. I'm currently working on this, and expect to have a patch by end of next week.

@monkpow
Copy link
Collaborator

monkpow commented Jul 2, 2018

@JSchneidler I'm continuing to work on this. I have a large scale change that I am replacing the request mechanism, and it will close this and several other large requests. It's taking a little longer than I had hoped, but I wanted to check in and let you know its proceeding, and I hope to be done in the next week or so.

Thanks for your patience.

@JSlain
Copy link

JSlain commented Nov 23, 2018

Are the changes in place?
I definitely need this feature.

@EGI-ILM
Copy link

EGI-ILM commented Nov 8, 2023

Any news on this by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants