Player->fixNameIfCached()

villermen · Feb 4, 2018 · fad44ef · fad44ef
1 parent 525428b
commit fad44ef
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/Player.php b/src/Player.php
@@ -55,13 +55,27 @@ public function __construct(string $name, PlayerDataFetcher $dataFetcher = null)
      *
      * @return Player
      */
-    public function fixName()
+    public function fixName(): Player
     {
         $this->name = $this->getDataFetcher()->fetchRealName($this->getName());
 
         return $this;
     }
 
+    /** @noinspection PhpDocMissingThrowsInspection */
+    /**
+     * @return Player
+     */
+    public function fixNameIfCached(): Player
+    {
+        if ($this->getDataFetcher()->getCachedRealName($this->getName())) {
+            /** @noinspection PhpUnhandledExceptionInspection */
+            $this->fixName();
+        }
+
+        return $this;
+    }
+
     /**
      * @return SkillHighScore
      * @throws FetchFailedException

diff --git a/test/PlayerTest.php b/test/PlayerTest.php
@@ -46,7 +46,7 @@ public function testDataFetchingAndCaching()
         self::assertSame($oldSchoolActivityHighScore, $this->player->getOldSchoolActivityHighScore());
         self::assertGreaterThanOrEqual(0, $oldSchoolActivityHighScore->getActivity(Activity::ACTIVITY_OLD_SCHOOL_MASTER_CLUE_SCROLLS)->getScore());
 
-        $this->player->fixName();
+        $this->player->fixNameIfCached();
         self::assertEquals("Excl", $this->player->getName());
     }