Fix incorrect gui colors in jellybeans theme #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisbra This PR is almost here for around 8 months, please comment. |
|
I have nothing to say to the jellybean theme unfortunately. Sorry it took so long, let me merge it in then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed incorrect section colors when using
set termguicolorswith jellybeans theme.It can easily be seen that gui colors are respectively defined as cterm colors except for several cases, this PR fixes this :) The issue was similar in both insert and replace mode. Attached herewith an illustration for insert mode.
Before proposed fix, it looked like this:
After proposed fix, it looks correct:
Best,
gfszr