Add separated option to set formatting column limit #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes sense, but it shouldn't be a global variable, but rather a buffer local variable. |
chtenb
reviewed
Apr 26, 2021
| @@ -21,13 +21,17 @@ if !exists('g:autoformat_verbosemode') | |||
| let g:autoformat_verbosemode = 0 | |||
| endif | |||
|
|
|||
| if !exists('b:autoformat_columnlimit') | |||
| let b:autoformat_columnlimit = &textwidth | |||
There was a problem hiding this comment.
This won't work because this line is only executed on program start. Whenever a new buffer is opened this variable should be synced. However, I'm realizing now that this is a can of worms, since the textwidth can be manipulated by other scripts and it is unclear when it is safe to flush it to the columnlimit variable.
|
See my other inline comment. I think it is better to override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textwidth's side effects (like forcing to wrap line) may be disliked by some developers.A separated option for column limit helps developers to set it to a maybe more "modern" value, like 120.