Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing a highlighting of number literals with type suffixes #17

Closed
olehdevua opened this issue Sep 19, 2015 · 6 comments
Closed

missing a highlighting of number literals with type suffixes #17

olehdevua opened this issue Sep 19, 2015 · 6 comments

Comments

@olehdevua
Copy link

when I write

a = 43

then 43 is highlighted, but when I write

a = 43i32
b = 0x34f64

then the number literals is not highlighted
@rhysd
Copy link
Member

rhysd commented Sep 20, 2015

It seems that literal suffixes remove underscores (e.g. _u32 -> u32). I'll fix them.

@rhysd
Copy link
Member

rhysd commented Sep 21, 2015

I understood the behavior.
All of below are valid suffix...

0.1f64
0.1_f64
0.1__f64
0.1__________f64

rhysd added a commit that referenced this issue Sep 21, 2015
@rhysd
fix literal suffix highlights (#17)
134b48e
@rhysd
Copy link
Member

rhysd commented Sep 21, 2015

@olegtsyba

Looks good?

screenshot

@olehdevua
Copy link
Author

the trouble is that

1anychars

is now highlighted

rhysd added a commit that referenced this issue Sep 23, 2015
@rhysd
allow only i32, f32, ... as literal suffixes
704722f 
Related issue: #17
@rhysd
Copy link
Member

rhysd commented Sep 23, 2015

@olegtsyba

I limited suffixes to i32, i64, f32, f64, u32 and u64.
Does it look good?

ss

@olehdevua
Copy link
Author

I think it works correctly now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhysd @olehdevua