🐛 Re-export BatchError class and fix documentation of buffer.concrete
#232
Conversation
The current `concrete` function won't touch options mentioned in the documentation.
It seems `vim` code block annotation cause 500 error on
denoland/docland. I'm not sure if this is the reason why documentation
of denops_std is not generated but try
[uncaught application error]: Error - Unknown language: `vim` is not registered
request: {
url: "http://0.0.0.0:8080/https://raw.githubusercontent.com/vim-denops/deno-denops-std/main/argument/mod.t"... 1 more character,
method: "GET",
hasBody: false
}
response: { status: 500, type: "html", hasBody: true, writable: true }
at a (https://esm.sh/v91/fault@2.0.1/denonext/fault.mjs:2:312)
at Object.u [as highlight] (https://esm.sh/v91/lowlight@2.4.1/denonext/lowlight.mjs:2:2820)
at syntaxHighlight (file:///Users/alisue/ghq/github.com/denoland/docland/components/common.tsx:148:27)
at MarkdownBlock (file:///Users/alisue/ghq/github.com/denoland/docland/components/markdown.tsx:101:28)
at renderFunctionalComponent (https://deno.land/x/nano_jsx@v0.0.33/core.ts:160:18)
at _render (https://deno.land/x/nano_jsx@v0.0.33/core.ts:134:70)
at https://deno.land/x/nano_jsx@v0.0.33/core.ts:46:17
at Array.forEach (<anonymous>)
at appendChildren (https://deno.land/x/nano_jsx@v0.0.33/core.ts:41:12)
at h (https://deno.land/x/nano_jsx@v0.0.33/core.ts:286:3)
[error] Error: Unknown language: `vim` is not registered
at a (https://esm.sh/v91/fault@2.0.1/denonext/fault.mjs:2:312)
at Object.u [as highlight] (https://esm.sh/v91/lowlight@2.4.1/denonext/lowlight.mjs:2:2820)
at syntaxHighlight (file:///Users/alisue/ghq/github.com/denoland/docland/components/common.tsx:148:27)
at MarkdownBlock (file:///Users/alisue/ghq/github.com/denoland/docland/components/markdown.tsx:101:28)
at renderFunctionalComponent (https://deno.land/x/nano_jsx@v0.0.33/core.ts:160:18)
at _render (https://deno.land/x/nano_jsx@v0.0.33/core.ts:134:70)
at https://deno.land/x/nano_jsx@v0.0.33/core.ts:46:17
at Array.forEach (<anonymous>)
at appendChildren (https://deno.land/x/nano_jsx@v0.0.33/core.ts:41:12)
at h (https://deno.land/x/nano_jsx@v0.0.33/core.ts:286:3)
`BatchError` is a class, not a type. This commit fixes the re-export.
WalkthroughThe recent modifications streamline the export process of types within modules and refine the functionality of buffer management. By shifting from individual type exports to module-level exports, the changes enhance code maintainability and readability. Additionally, the adjustment in buffer options and behavior during Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 82.91% 82.91%
=======================================
Files 48 48
Lines 2658 2658
Branches 232 232
=======================================
Hits 2204 2204
Misses 454 454 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- argument/mod.ts (3 hunks)
- buffer/buffer.ts (1 hunks)
- mod.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- argument/mod.ts
Additional comments: 2
mod.ts (1)
- 62-67: The export statement correctly uses TypeScript's
typekeyword for type-only imports, aligning with best practices for type exporting. This change simplifies the import process for users.buffer/buffer.ts (1)
- 388-393: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Ensure that the removal of specific options (
buftype,swapfile,modifiable) and the synchronous restoration of buffer content onBufReadCmdare correctly implemented and documented, as these changes are crucial for the functionality and usability ofbuffer.concrete.
SSIA
Summary by CodeRabbit