-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix behavior on verbose
environment
#244
Conversation
WalkthroughThis update includes various modifications to the project, focusing on enhancing functionality and improving code clarity. Key changes involve renaming commands in workflows and tasks, modifying verbose settings in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 82.52% 82.53% +0.01%
==========================================
Files 57 57
Lines 2964 2966 +2
Branches 262 262
==========================================
+ Hits 2446 2448 +2
Misses 516 516
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- .github/workflows/update.yml (1 hunks)
- autocmd/common.ts (1 hunks)
- autocmd/common_test.ts (2 hunks)
- deno.jsonc (1 hunks)
- helper/expr_string.ts (1 hunks)
- helper/keymap.ts (1 hunks)
- mapping/mod.ts (1 hunks)
- mapping/mod_test.ts (3 hunks)
Additional comments not posted (9)
deno.jsonc (2)
7-7
: Addition ofdeno check ./**/*.ts
enhances type safety across the project.
11-12
: Modification of theupdate
task to specify exact permissions and use a specific CLI tool is a good security practice..github/workflows/update.yml (1)
21-21
: Update of the workflow command fromupgrade:commit
toupdate:commit
maintains consistency with task changes indeno.jsonc
.helper/keymap.ts (1)
11-11
: Change of import statement foris
module to named import enhances clarity and aligns with module export changes.autocmd/common.ts (1)
134-134
: Prefixing0verbose
in thelist
function suppresses verbose output, aligning with the PR's objective to manage verbose environments effectively.mapping/mod.ts (1)
219-222
: Inclusion of0verbose
in thelist
function command suppresses verbose output, consistent with changes across other modules to manage verbose environments.helper/expr_string.ts (1)
29-29
: Change of import statement foris
module to named import enhances clarity and aligns with module export changes.autocmd/common_test.ts (1)
Line range hint
166-201
: Addition of steps to save and restore theverbose
setting in tests ensures that global settings are not inadvertently affected, enhancing test reliability.mapping/mod_test.ts (1)
Line range hint
570-622
: Addition of steps to save and restore theverbose
setting in tests ensures that global settings are not inadvertently affected, enhancing test reliability.
Summary by CodeRabbit
New Features
list
function to provide more detailed output using0verbose
.Bug Fixes
verbose
setting after listing autocmds to ensure consistent user environment.Chores
Tests
verbose
settings during tests.