Slight performance improvement by minor changes #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.... I have tested it and it brokes ddc.vim plugin. |
It broke ddc.vim like...? Does ddc.vim access private APIs (APIs not in |
|
ddc.vim registers plugin manually. I think it does not work. call denops#plugin#register('ddc',
\ denops#util#join_path(s:root_dir, 'denops', 'ddc', 'app.ts'),
\ { 'mode': 'skip' }) |
It seems the number of imports and its content influence load performance. denoland/deno#12519
`DedicatedWorkerGlobalScope` is missing in Deno thus we use `Worker` instead for `self` and it does not have `terminate()` method so use proper `close()` method instead.
Errors on those autocmd should not directly influence the plugin loading so echo error messages and continue.
…luginPost It seems dynamic imports costs a bit so we immediately import the script in background and wait completion between DenopsPluginPre/DenopsPluginPost to improve performance a bit. denoland/deno#12519
lambdalisue
force-pushed
the
improve-performance
branch
2 times, most recently
from
d78ea77
to
7a7b23a
Compare
|
@Shougo Fixed (and force pushed). Could you try again? |
|
OH, it works. |
Shougo
approved these changes
Oct 31, 2021
All denops plugin refer `mod.ts` directly/indirectly means that all denops plugins refer `denops.ts` indirectly thus the size of `denops.ts` should be as small as possible.
lambdalisue
force-pushed
the
improve-performance
branch
from
3a646d5
to
87eaf53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After