Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for neovim 0.10 #248

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Fix for neovim 0.10 #248

merged 2 commits into from
Apr 24, 2023

Conversation

Shougo
Copy link
Contributor

@Shougo Shougo commented Apr 22, 2023

health#report_XXX is deprecated in neovim 0.10.

@Shougo Shougo requested a review from lambdalisue April 22, 2023 23:26
call v:lua.vim.health.error(a:report)
else
call health#report_error(a:report)
endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite it like

if has('nvim-0.10')
  function! s:report_ok(report) abort
    call v:lua.vim.health.ok(a:report)
  endfunction

  " ...etc
else
  function s:report_ok(report) abort
    call healtp#report_ok(a:report)
  endfunction

  " ...etc
endif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lambdalisue lambdalisue merged commit d7a1561 into main Apr 24, 2023
9 checks passed
@lambdalisue lambdalisue deleted the checkhealth branch April 24, 2023 05:43
@Shougo
Copy link
Contributor Author

Shougo commented Apr 24, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants