Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use msgpack-rpc client type on Neovim #271

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

lambdalisue
Copy link
Member

@lambdalisue lambdalisue marked this pull request as draft August 6, 2023 19:13
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bfdc079) 92.59% compared to head (fe3235a) 92.59%.

❗ Current head fe3235a differs from pull request most recent head 987e84d. Consider uploading reports for the commit 987e84d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           3        3           
  Lines          81       81           
  Branches        6        6           
=======================================
  Hits           75       75           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue
Copy link
Member Author

lambdalisue commented Aug 26, 2023

Prior to neovim/neovim#24399, Neovim does not have msgpack-rpc client type but client type was not actually refered so we can simply merge this. (it should works well on previous Neovim as well)

@lambdalisue lambdalisue force-pushed the use-msgpack-rpc-client-on-neovim branch from fe3235a to 987e84d Compare August 26, 2023 12:24
@lambdalisue lambdalisue marked this pull request as ready for review August 26, 2023 12:29
@lambdalisue lambdalisue merged commit a80e4d8 into main Aug 26, 2023
9 checks passed
@lambdalisue lambdalisue deleted the use-msgpack-rpc-client-on-neovim branch August 26, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes connection closed by channel error
1 participant