🐛 Fix always use last callback at wait_async()
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 3 3
Lines 81 81
Branches 6 6
=======================================
Hits 75 75
Misses 6 6 ☔ View full report in Codecov by Sentry. |
kuuote
force-pushed
the
fix-multiple-wait_async
branch
2 times, most recently
from
a44d9d2
to
81b98c5
Compare
uga-rosa
added a commit
to uga-rosa/denippet.vim
that referenced
this pull request
Sep 2, 2023
revert when this PR is merged vim-denops/denops.vim#275
lambdalisue
requested changes
Sep 7, 2023
kuuote
force-pushed
the
fix-multiple-wait_async
branch
from
81b98c5
to
b9cf1b0
Compare
lambdalisue
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
wait_async()callback is called in loop and usingtimer_start(). It was handled after the loop was turned.I splited timer call to function. It creates new callstack independent for loop.
Fix #274