Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☕ Change action-setup-vim to rhysd/action-setup-vim #290

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

lambdalisue
Copy link
Member

@lambdalisue lambdalisue commented Nov 26, 2023

Just trying to fix.

Summary by CodeRabbit

  • Chores

    • Updated the GitHub Actions workflow to enhance the setup process for Vim and Neovim environments.
  • Refactor

    • Streamlined the configuration parameters for setting up Vim and Neovim in the continuous integration pipeline.

Copy link

coderabbitai bot commented Nov 26, 2023

Warning

Rate Limit Exceeded

@lambdalisue has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 15 minutes and 38 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 85b30d1 and ddab969.

Walkthrough

The GitHub Actions workflow has been updated to change the Vim setup action and modify configuration parameters. The thinca/action-setup-vim action is replaced with rhysd/action-setup-vim, and the setup process for Vim and Neovim has been streamlined with updated input names and output references.

Changes

File Path Change Summary
.github/workflows/test.yml Replaced thinca/action-setup-vim@v1 with rhysd/action-setup-vim@v1, updated vim_type and vim_version parameters to neovim: true and version, and changed output references from *_path to executable.

🐇✨
In the realm of code, where actions flow,
A rabbit tweaked the workflow's glow.
Vim's old paths, now a tale,
Neovim's setup, set to sail. 🚀
🌟🐾


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8b53173 and 85b30d1.
Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
Additional comments: 1
.github/workflows/test.yml (1)
  • 68-100:

The changes to the GitHub Actions workflow file are correct and align with the updates described in the pull request summary. The use of rhysd/action-setup-vim@v1 with the new input parameters and the updated output variable names are consistent with the intended changes. The workflow appears to be correctly configured for both Vim and Neovim environments.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b53173) 92.59% compared to head (ddab969) 92.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           3        3           
  Lines          81       81           
  Branches        6        6           
=======================================
  Hits           75       75           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue lambdalisue merged commit 591abde into main Nov 26, 2023
16 checks passed
@lambdalisue lambdalisue deleted the fix-ci branch November 26, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant