-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo? in the document: "denops#call#register" #315
Conversation
WalkthroughThe update simplifies callback management in the Denops framework by consolidating functionality under a renamed function, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- doc/denops.txt (1 hunks)
Additional comments: 1
doc/denops.txt (1)
- 364-369: The documentation correctly reflects the renaming of
denops#call#register
todenops#callback#register
and provides examples for both persistent and one-time callbacks. Ensure that all references to the old function name have been updated throughout the documentation and codebase.Verification successful
The verification process confirms that the old function name
denops#call#register
does not appear in the codebase, and the new function namedenops#callback#register
is present and used as expected. The documentation and codebase reflect the changes described in the PR.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for the old function name in the documentation and codebase. rg --type vimscript 'denops#call#register' # Search for the new function name in the documentation and codebase. rg --type vimscript 'denops#callback#register'Length of output: 326
fixed to: "denops#callback#register"
Summary by CodeRabbit
Refactor
Documentation