Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim9class.{txt,jax} #1360

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Add vim9class.{txt,jax} #1360

merged 6 commits into from
Nov 17, 2023

Conversation

h-east
Copy link
Member

@h-east h-east commented Nov 10, 2023

マージする場合は
vim-jp/vimdoc-ja#278
もマージお願いします。

doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
doc/vim9class.jax Outdated Show resolved Hide resolved
Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずtypoの指摘を先に


多くの言語では、コンストラクタメソッドのクラス名が使用される。欠点は、多くの場
合、名前が長いことだ。また、クラス名を変更する場合は、すべてのコンストラクタメ
ソッドの名前を変更する必要がある。大したことではiないが、それでもデメリットは
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ソッドの名前を変更する必要がある。大したことではiないが、それでもデメリットは
ソッドの名前を変更する必要がある。大したことではないが、それでもデメリットは


8. 列挙型 *Vim9-enum* *:enum* *:endenum*

{not implemented yet}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment
{まだ実装されていない}、といった日本語はしないということでしょうか?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

普通に訳すとハイライトされないのでそのままにしていました。カッコ内の後ろに訳を入れてみました。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、了解です

@tsuyoshicho tsuyoshicho self-requested a review November 12, 2023 06:41
@h-east
Copy link
Member Author

h-east commented Nov 17, 2023

@tsuyoshicho 問題無ければ requested changes をオフにしてもらえますか?
もしくは、どこを直せていないか教えてください。

@h-east h-east merged commit 974e99b into master Nov 17, 2023
3 checks passed
@h-east h-east deleted the hh-add-vim9class branch November 17, 2023 22:43
@tsuyoshicho
Copy link
Contributor

応答遅れてすみません、たしかにそうでした

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants