Bitwise: Fix overflow from Vim 8.0.0219 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujihisa
approved these changes
Feb 8, 2017
test/Bitwise.vimspec
Outdated
| @@ -1,6 +1,11 @@ | |||
| Describe Bitwise | |||
| Before all | |||
| let B = vital#vital#new().import('Bitwise') | |||
| " NOTE: | |||
| " A int literal larger than or equal to 0x8000000000000000 will be rounded | |||
test/Bitwise.vimspec
Outdated
| @@ -1,6 +1,11 @@ | |||
| Describe Bitwise | |||
| Before all | |||
| let B = vital#vital#new().import('Bitwise') | |||
| " NOTE: | |||
| " A int literal larger than or equal to 0x8000000000000000 will be rounded | |||
| " to 0x7FFFFFFFFFFFFFFF after Vim 8.0.0219 so create it without literal | |||
test/Bitwise.vimspec
Outdated
| @@ -227,14 +232,20 @@ Describe Bitwise | |||
| if has('num64') | |||
| Context with 64bit number | |||
| It applies sign extension | |||
| " NOTE: | |||
| " A int literal larger than or equal to 0x8000000000000000 will be rounded | |||
| " to 0x7FFFFFFFFFFFFFFF after Vim 8.0.0219 so create it without literal | |||
Vim 8.0.0219 change the behavior of overflow and now any literal larger than or equal to 0x8000000000000000 will be rounded to 0x7FFFFFFFFFFFFFFF. To fix this problem, create values without using literal in code and tests.
|
テスト完了後にマージします |
k-takata
reviewed
Feb 8, 2017
| " to 0x7FFFFFFFFFFFFFFF after Vim 8.0.0219, so create it without literal | ||
| let s:xFFFFFFFF00000000 = has('patch-8.0.0219') | ||
| \ ? 0xFFFFFFFF * s:pow2[and(32, s:mask)] | ||
| \ : 0xFFFFFFFF00000000 |
There was a problem hiding this comment.
不要ですが
- 以前動いていた部分を変更する必要がない
- 変数名でわかりやすくしているが
0xFFFFFFFF00000000が動くならそれが正しいんだよ、ってのをコード的に表現したかった
って感じで分岐してます。関数呼び出しが一回分増えるコストがありますが、無視できるかなと
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vim 8.0.0219 change the behavior of overflow and now any literal
larger than or equal to 0x8000000000000000 will be rounded to
0x7FFFFFFFFFFFFFFF.
To fix this problem, create values without using literal in code and tests.
#479
こんなんでどうでしょう？