Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line argument list indentation broken (regression) #139

Closed
ngollan opened this issue Mar 12, 2013 · 3 comments
Closed

Multi-line argument list indentation broken (regression) #139

ngollan opened this issue Mar 12, 2013 · 3 comments
Labels

Comments

@ngollan
Copy link
Contributor

ngollan commented Mar 12, 2013

With commit 9d16028 multi-line argument lists outside parentheses do not indent correctly if preceded by a line with a symbol argument:

class A
  # next line is what breaks things
  thing :foo
  thing 'a',
  'b'

  # now with a non-symbol argument
  thing 'foo'
  thing 'a',
    'b'

end

Reverting the commit fixes things.

@AndrewRadev
Copy link
Member

I've reverted the commit and pushed to master. Could you confirm that it's currently okay?

@ngollan
Copy link
Contributor Author

ngollan commented Mar 12, 2013

Seems to help for my testcase… I'll close this in the hope that nothing depended on the original change ;-)

Thanks for your fast response.

@ngollan ngollan closed this as completed Mar 12, 2013
@AndrewRadev
Copy link
Member

Issue #132 depends on it, so I've reopened that one -- I'll have to figure out a better solution. Thanks for being a good Internet citizen and reporting :).

jtmkrueger pushed a commit to jtmkrueger/vim-ruby that referenced this issue Nov 5, 2013
A spec was implemented for vim-ruby#139.

The issue this commit fixes is: vim-ruby#132.

By adding the `Symbol` group to the "string or syntax" pattern, some
continuations are fixed. It should not be added to the "string" pattern,
however.
@dkearns dkearns added the indent label Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants