Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Multi-line argument list indentation broken (regression) #139

Closed
ngollan opened this Issue · 3 comments

2 participants

@ngollan

With commit 9d16028 multi-line argument lists outside parentheses do not indent correctly if preceded by a line with a symbol argument:

class A
  # next line is what breaks things
  thing :foo
  thing 'a',
  'b'

  # now with a non-symbol argument
  thing 'foo'
  thing 'a',
    'b'

end

Reverting the commit fixes things.

@AndrewRadev
Collaborator

I've reverted the commit and pushed to master. Could you confirm that it's currently okay?

@ngollan

Seems to help for my testcase… I'll close this in the hope that nothing depended on the original change ;-)

Thanks for your fast response.

@ngollan ngollan closed this
@AndrewRadev
Collaborator

Issue #132 depends on it, so I've reopened that one -- I'll have to figure out a better solution. Thanks for being a good Internet citizen and reporting :).

@jtmkrueger jtmkrueger referenced this issue from a commit in jtmkrueger/vim-ruby
@AndrewRadev AndrewRadev Fix continuation issue again
A spec was implemented for vim-ruby#139.

The issue this commit fixes is: vim-ruby#132.

By adding the `Symbol` group to the "string or syntax" pattern, some
continuations are fixed. It should not be added to the "string" pattern,
however.
260897a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.