Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the public access modifier keyword #184

Conversation

drn
Copy link
Contributor

@drn drn commented Nov 1, 2013

@AndrewRadev - see comments in the other pull ( #179 )

@drn drn mentioned this pull request Nov 1, 2013
@@ -6,6 +6,7 @@ There are a number of options to the Ruby syntax highlighting.
2. Whitespace errors |ruby_space_errors|
3. Folds |ruby_fold|
4. Reducing expensive operations |ruby_no_expensive| |ruby_minlines|
5. Reducing expensive operations |ruby_indent_access_modifier_style|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be "Access modifier indentation".

@AndrewRadev
Copy link
Member

Thanks for your work! I commented on one simple omission, but the bigger problem with the documentation is that it's under the ft-ruby-syntax section of the docs. Could you move that to doc/vim-ruby.txt? This is a file that, regrettably, doesn't go in the official docs, but is still accessible as documentation. We put all the "extras" in there.

@drn
Copy link
Contributor Author

drn commented Nov 3, 2013

@AndrewRadev - kay np! updated the docs

@drn
Copy link
Contributor Author

drn commented Nov 3, 2013

feel free to merge and squash the fixup

@AndrewRadev AndrewRadev merged commit c277b5b into vim-ruby:private-protected-indenting Nov 3, 2013
@drn drn deleted the outdent-indentkeys-support branch November 3, 2013 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants