Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixing of bracket and non-bracket continuations #219

Merged
merged 1 commit into from Jul 14, 2014
Merged

Fix mixing of bracket and non-bracket continuations #219

merged 1 commit into from Jul 14, 2014

Conversation

odcinek
Copy link
Contributor

@odcinek odcinek commented Jul 8, 2014

Address #17

@AndrewRadev AndrewRadev merged commit d1e79ae into vim-ruby:master Jul 14, 2014
@AndrewRadev
Copy link
Member

I've pushed your fix, although I'm kind of nervous about it. I can't help but think there will be some odd edge cases, and this particular issue seems like an edge case itself to me.

For starters, this example does not indent correctly:

response == "OK" or
  response == "1) menu item" or
 response == "2) menu item"

The reason is that, while s:Match checks whether the match is on a string, it can only check the beginning and end of the match (checking the entire body of the string would be too much work). As a result, the match was failing in the case of a ) in a string. I've fixed this in e36da34, but I can't help but think there will be more problems like this. If something like that happens, I'll revert the commits and open discussion here, to see what we can do.

In any case, thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants