Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight group for parentheses #396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tyok
Copy link
Contributor

@tyok tyok commented Mar 22, 2019

Hi,

I tried adding a highlight group for parentheses and so far it's been working.

I have to remove a line because methods with only keyword arguments didn't behave properly:

User.where("name = :name", name: "John") # The parens gets highlighted as expected
User.new(name: "John")  # The parens didn't get highlighted
User.new( name: "John") # Strangely, this works fine

I tried to find out if the removed line will break anything, but nothing so far. I think it was supposed to prevent highlighting some symbol name as keyword (0e58499), but I have checked that it's still working without that line. I probably should mention that I don't understand what the regex means.

Please tell me if there's a better way. Thanks for your time.

@dkearns dkearns added the syntax label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants