This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
only run phpcs if the file has no syntax errors. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running phpcs on a file which contains a parse error generates a huge number of warnings from the phpcs library. This can freeze vim for minutes at a time while it attempts to parse these notices/warnings/errors. Therefore - don't run phpcs on files which have parse errors.
scrooloose
added a commit
that referenced
this pull request
Jan 25, 2012
only run phpcs if the file has no syntax errors.
|
Pulled - good idea :-) |
|
U iz fast :) |
Merged
technosophos
added a commit
to technosophos/syntastic
that referenced
this pull request
Feb 7, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running phpcs on a file which contains a parse error may generate a huge
number of warnings from the phpcs library.
You can see an example of what phpcs outputs in such cases here: https://gist.github.com/6c6535c3fc22c754ca6b
Therefore - don't run phpcs on files which have parse errors; don't freeze vim for minutes at a time when syntastic is already aware that the file is fundamentally borked