Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for codeception .dist.yml #654

Merged
merged 1 commit into from
May 24, 2022
Merged

Add support for codeception .dist.yml #654

merged 1 commit into from
May 24, 2022

Conversation

DanielSiepmann
Copy link
Contributor

@DanielSiepmann DanielSiepmann commented May 18, 2022

Extend detection for codeception test file.
Respect codeception.dist.yml beside codeception.yml.

As documented by https://codeception.com/docs/reference/Configuration#Configuration-Templates-distyml

Make sure these boxes are checked before submitting your pull request:

  • Add fixtures and spec when implementing or updating a test runner
  • Update the README accordingly
  • Update the Vim documentation in doc/test.txt

@DanielSiepmann
Copy link
Contributor Author

I don't know how to extend https://github.com/vim-test/vim-test/blob/master/spec/codeception_spec.vim as I guess we would need to change the structure of https://github.com/vim-test/vim-test/tree/master/spec/fixtures/codeception ?
How would you like me to adapt tests, add another spec.vim which uses a different fixture folder?

@codeinabox
Copy link
Collaborator

I don't know how to extend https://github.com/vim-test/vim-test/blob/master/spec/codeception_spec.vim as I guess we would need to change the structure of https://github.com/vim-test/vim-test/tree/master/spec/fixtures/codeception ? How would you like me to adapt tests, add another spec.vim which uses a different fixture folder?

Thank you for this! As for the spec I'd do something like this:

  it "also recognizes codeception.dist.yml"
    try
      !mv codeception.yml codeception.dist.yml
      view tests/functional/NormalCest.php
      TestSuite

      Expect g:test#last_command == 'codecept run'
    finally
      !mv codeception.dist.yml codeception.yml
    endtry
  end

Extend detection for codeception test file.
Respect codeception.dist.yml beside codeception.yml.

As documented by https://codeception.com/docs/reference/Configuration#Configuration-Templates-distyml
Copy link
Collaborator

@codeinabox codeinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to add a test, very much appreciated

@codeinabox codeinabox merged commit 505ff1a into vim-test:master May 24, 2022
@DanielSiepmann DanielSiepmann deleted the extend-codeception-detection branch May 24, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants