Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
runtime: fix :compiler leaving behind a g:makeprg variable (#14414)
Problem: :compiler may leave behind a g:makeprg variable after #14336. Solution: Use a script local variable. Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
- Loading branch information
Showing
2 changed files
with
6 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b73faa1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkearns Is a spurious s:makeprg preferred? How about using &l:makeprg, being overwritten anyway?
Edit: I see this has been "discussed" at #14414
b73faa1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Konfekt, that eye-roll in the comment was directed at myself. The differences between legacy and Vim9 script are causing me to frequently miss things like that these days.
Personally, I'd do away with the variable altogether but it's common to 'style' things that way.