patch 8.0.0595: Coverity warning for not checking return value

Problem: Coverity warning for not checking return value of dict_add(). Solution: Check the return value for FAIL.
vim · May 1, 2017 · beb9cb1 · beb9cb1
1 parent 66c0e70
commit beb9cb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/quickfix.c b/src/quickfix.c
@@ -4722,7 +4722,8 @@ get_errorlist_properties(win_T *wp, dict_T *what, dict_T *retdict)
 	    if (di != NULL)
 	    {
 		copy_tv(qi->qf_lists[qf_idx].qf_ctx, &di->di_tv);
-		dict_add(retdict, di);
+		if (dict_add(retdict, di) == FAIL)
+		    dictitem_free(di);
 	    }
 	}
 	else

diff --git a/src/version.c b/src/version.c
@@ -764,6 +764,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    595,
 /**/
     594,
 /**/