Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vex is broken in latest build #12304

Closed
DanielViberg opened this issue Apr 26, 2023 · 7 comments
Closed

Vex is broken in latest build #12304

DanielViberg opened this issue Apr 26, 2023 · 7 comments
Assignees

Comments

@DanielViberg
Copy link

Steps to reproduce

  1. Start vim
  2. :Vex
  3. :q
  4. :Vex
  5. Observe two explorer windows

Expected behaviour

Only one explorer window was the earlier behaviour

Version of Vim

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Apr 26 2023 08:28:40) Included patches: 1-1488

Environment

Ubuntu 23.04
Gnome-terminal
xterm-256color: command not found
Gnome

Logs and stack traces

No response

@k-takata
Copy link
Member

Cc: @cecamp

@stac47
Copy link

stac47 commented May 2, 2023

This bug is a bit cumbersome: when we have several windows and do :Explore, the current and the "next" windows display the files in netrw.

This bug appeared on 9.0.1479 if this can help.

@chrisbra
Copy link
Member

chrisbra commented May 2, 2023

Looks like there is a typo in netrws s:NetrwEditBuf() function. This patch fixes it:

diff --git a/runtime/autoload/netrw.vim b/runtime/autoload/netrw.vim
index 1372de4df..7bb131042 100644
--- a/runtime/autoload/netrw.vim
+++ b/runtime/autoload/netrw.vim
@@ -5734,7 +5734,7 @@ fun! s:NetrwEditBuf(bufnum)
    exe "sil! NetrwKeepj keepalt noswapfile b ".fnameescape(a:bufnum)
   else
 "   call Decho("exe sil! NetrwKeepj noswapfile b ".fnameescape(a:bufnum))
-   exe "sil! NetrwKeepj noswapfile b ".fnameescape(a:bufnume)
+   exe "sil! NetrwKeepj noswapfile b ".fnameescape(a:bufnum)
   endif
 "  call Dret("s:NetrwEditBuf")
 endfun

@DanielViberg
Copy link
Author

Can confirm, @chrisbra has solved this issue.

@cecamp
Copy link
Collaborator

cecamp commented May 3, 2023

Thank you, Christian -- I was attending a wedding without a computer and so couldn't address this.

@cecamp cecamp closed this as completed May 3, 2023
@DKurilo
Copy link

DKurilo commented May 3, 2023

@cecamp , is it closed because PR created?
I mean I can apply it locally, but I don't want to do it each time after update. :)

@cederom
Copy link

cederom commented Jun 12, 2023

Thank you for the fix! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants