Fix heap-use-after-free when using synstack() and synID() in WinEnter #10204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10204 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 167 167
Lines 187956 187957 +1
Branches 42381 42381
=======================================
+ Hits 154087 154091 +4
+ Misses 21521 21518 -3
Partials 12348 12348
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zeertzjq
force-pushed
the
fix-syntax-use-after-free
branch
from
0851886
to
a5a033f
Compare
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Apr 16, 2022
…n WinEnter Problem: Using freed memory when using synstack() and synID() in WinEnter. Solution: Check using the syntax window. (closes vim/vim#10204) vim/vim@ca7e86c
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Apr 16, 2022
…n WinEnter (#18136) Problem: Using freed memory when using synstack() and synID() in WinEnter. Solution: Check using the syntax window. (closes vim/vim#10204) vim/vim@ca7e86c
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Apr 17, 2022
…n WinEnter (neovim#18136) Problem: Using freed memory when using synstack() and synID() in WinEnter. Solution: Check using the syntax window. (closes vim/vim#10204) vim/vim@ca7e86c (cherry picked from commit dcf7bc4)
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
…n WinEnter (neovim#18136) Problem: Using freed memory when using synstack() and synID() in WinEnter. Solution: Check using the syntax window. (closes vim/vim#10204) vim/vim@ca7e86c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes heap-use-after-free:
Adding a
wp != syn_winseems to fix this.