Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker error with Python 3.11 #10627

Closed
wants to merge 1 commit into from
Closed

Linker error with Python 3.11 #10627

wants to merge 1 commit into from

Conversation

zdohnal
Copy link
Contributor

@zdohnal zdohnal commented Jun 27, 2022

Problem: Linker error with dynamic Python 3.11, because
_PyObject_TypeCheck is no longer available in Python3.11

Solution: Undefine PyObject_TypeCheck() from Python3.11 and define it
internally in Vim if Python is 3.11.0.b3 or higher.

OS: Fedora 37
Vim: 8.2.5167

How to reproduce:

  1. ./configure --enable-python3interp=dynamic --enable-gui=no --with-features=Huge
  2. make

Problem: Linker error with dynamic Python 3.11, because
_PyObject_TypeCheck is no longer available in Python3.11
Solution: Undefine PyObject_TypeCheck() from Python3.11 and define it
internally in Vim if Python is 3.11.0.b3 or higher.
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #10627 (89cdcd5) into master (1ae8c26) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10627      +/-   ##
==========================================
- Coverage   81.77%   81.70%   -0.08%     
==========================================
  Files         158      158              
  Lines      185251   185412     +161     
  Branches    41855    41938      +83     
==========================================
- Hits       151493   151487       -6     
- Misses      21300    21469     +169     
+ Partials    12458    12456       -2     
Flag Coverage Δ
huge-clang-none 82.60% <ø> (+<0.01%) ⬆️
linux 82.60% <ø> (+<0.01%) ⬆️
mingw-x64-HUGE 0.00% <ø> (?)
mingw-x64-HUGE-gui 78.13% <ø> (-0.01%) ⬇️
windows 76.91% <ø> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/if_python3.c 72.54% <ø> (-0.68%) ⬇️
src/profiler.c 82.48% <0.00%> (-1.12%) ⬇️
src/os_win32.c 57.49% <0.00%> (-0.91%) ⬇️
src/locale.c 75.43% <0.00%> (-0.90%) ⬇️
src/os_mswin.c 48.94% <0.00%> (-0.63%) ⬇️
src/gui_dwrite.cpp 45.93% <0.00%> (-0.56%) ⬇️
src/terminal.c 77.06% <0.00%> (-0.37%) ⬇️
src/gui_w32.c 34.83% <0.00%> (-0.37%) ⬇️
src/winclip.c 59.67% <0.00%> (-0.25%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae8c26...89cdcd5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants