Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More 'nosplitscroll' problems #11166

Closed
wants to merge 5 commits into from
Closed

Commits on Sep 18, 2022

  1. update_topline() is needed to avoid flicker in curs_columns()

    Problem:	Text flickers if we always skip update_topline() in
    curs_columns() for 'nosplitscroll'.
    Solution:	Only skip update_topline() while executing
    win_fix_scroll()(Fix vim#11158).
    luukvbaal committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    307a72c View commit details
    Browse the repository at this point in the history
  2. text is scrolled for 'nosplitscroll' when changing tabpage

    Problem:	Text is scrolled for 'nosplitscroll' when changing
    tab page.
    Solution:	Skip win_fix_scroll() call when changing tab page
    (Fix vim#11159).
    luukvbaal committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    20bb9e4 View commit details
    Browse the repository at this point in the history
  3. text scrolls for 'nosplitscroll' in terminal mode

    Problem:	Text scrolls for 'nosplitscroll' in terminal callback
    because State is not updated yet.
    Solution:	Treat terminal mode as normal mode in win_fix_cursor()
    (Fix vim#11160).
    luukvbaal committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    a0efd27 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. update 'nosplitscroll' tests.

    Problem:	'nosplitscroll' tests are outdated.
    Solution:	Add tests for various fixes, fix 'scrolloff' not being
    tested.
    luukvbaal committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    cd9756e View commit details
    Browse the repository at this point in the history
  2. cursor position changes in insert mode with 'nosplitscroll'

    Problem:	Cursor position changes in insert mode with
    'nosplitscroll' and 'scrolloff' in a small window.
    Solution	Replace previously erroneous workaround by
    validate_botline win() call in win_fix_cursor().
    luukvbaal committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    319a9ae View commit details
    Browse the repository at this point in the history