feat: solidity.vim of syntax, indent, ftplugin #11240
Conversation
|
Is this one better than the previous PR? |
|
The file does not set b:current_syntax |
|
This one seems to be older. There is also a typo in header. |
|
There was a bit of confusion about license. So I made a mistake, then I PR it again. thank you |
|
The original repository (https://github.com/tomlion/vim-solidity) has not only the syntax file but also the indent file and the ftplugin file. |
|
I think It would be good to add them together. I added the necessary file for supporting solidity ( thx |
cothi
changed the title
There was a problem hiding this comment.
The indent plugin needs to have b:undo_indent set as well to undo the setting of 'smartindent', 'indentexpr' and 'indentkeys'. See :help undo_indent for details.
Could you please also add yourself to https://github.com/vim/vim/blob/master/.github/CODEOWNERS?
| " Original author: tomlion (https://github.com/tomlion/vim-solidity) | ||
| " Last Changed: 2022 Sep 27 | ||
|
|
||
| setlocal commentstring=//\ %s |
There was a problem hiding this comment.
b:undo_ftplugin needs to be set. See :help undo_ftplugin
Setting 'comments' as well while you're here would be a good idea.
| " Vim filetype plugin file | ||
| " Language: Solidity | ||
| " Previous Maintainer: Cothi (jiungdev@gmail.com) | ||
| " Original author: tomlion (https://github.com/tomlion/vim-solidity) |
There was a problem hiding this comment.
Simply using Author: here is more 'standard' and is recognised by the syntax highlighters.
| " Language: Solidity | ||
| " Acknowledgement: Based off of vim-javascript | ||
| " Maintainer: Cothi (jiungdev@gmail.com) | ||
| " Original author: tomlion (https://github.com/tomlion/vim-solidity) |
There was a problem hiding this comment.
Simply using Author: here is more 'standard' and is recognised by the syntax highlighters.
|
@cothi any updates please? |
Set undo_{ftplugin,indent}
Finalises vim#11240
Set undo_{ftplugin,indent}
Finalises vim#11240
runtime(solidity): add new ftplugin (vim/vim#12877) Set undo_{ftplugin,indent} closes vim/vim#11240 vim/vim@e34b51e Co-authored-by: dkearns <dougkearns@gmail.com> Co-authored-by: cothi <jiungdev@gmail.com>
runtime(solidity): add new ftplugin (vim/vim#12877) Set undo_{ftplugin,indent} closes vim/vim#11240 vim/vim@e34b51e Co-authored-by: dkearns <dougkearns@gmail.com> Co-authored-by: cothi <jiungdev@gmail.com>
Set undo_{ftplugin,indent}
closes vim#11240
Co-authored-by: cothi <jiungdev@gmail.com>
Set undo_{ftplugin,indent}
closes vim#11240
Co-authored-by: cothi <jiungdev@gmail.com>
hi, I looked it up and found that the syntax solidity file was missing. How about supporting solidity syntax?